https://github.com/cor3ntin approved this pull request.
LGTM modulo nits
https://github.com/llvm/llvm-project/pull/130447
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/130447
>From bcce55dcadd3eb57f9cd4e7cf26c5d4da71970cf Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Sat, 8 Mar 2025 20:32:14 -0300
Subject: [PATCH] [clang] fix matching of nested template template parameters
W
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/130447
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11363,14 +11363,16 @@ class Sema final : public SemaBase {
/// The context in which we are checking a template parameter list.
enum TemplateParamListContext {
-TPC_ClassTemplate,
-TPC_VarTemplate,
+// For this context, Class, Variable, TypeAlias, and non-pa
@@ -602,6 +602,11 @@ namespace regression3 {
template class B {};
template struct A>;
} // namespace regression3
+namespace regression4 {
cor3ntin wrote:
```suggestion
namespace GH130362 {
```
https://github.com/llvm/llvm-project/pull/130447
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/130447
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/130447
>From 78ac2f4cbc45c4f77aab5e28e3450e9c459b8077 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Sat, 8 Mar 2025 20:32:14 -0300
Subject: [PATCH] [clang] fix matching of nested template template parameters
W
@@ -11363,14 +11363,17 @@ class Sema final : public SemaBase {
/// The context in which we are checking a template parameter list.
enum TemplateParamListContext {
-TPC_ClassTemplate,
-TPC_VarTemplate,
+// For this context, Class, Variable, TypeAlias, and non-pa
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/130447
>From b225cdcfcb008ffa80b6f48476665980de66eac0 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Sat, 8 Mar 2025 20:32:14 -0300
Subject: [PATCH] [clang] fix matching of nested template template parameters
W
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/130447
>From 0a41cc6f9e931df2a7dcbcf0ec35b2b7af8ad0d7 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Sat, 8 Mar 2025 20:32:14 -0300
Subject: [PATCH] [clang] fix matching of nested template template parameters
W
@@ -11363,14 +11363,17 @@ class Sema final : public SemaBase {
/// The context in which we are checking a template parameter list.
enum TemplateParamListContext {
-TPC_ClassTemplate,
-TPC_VarTemplate,
+// For this context, Class, Variable, TypeAlias, and non-pa
@@ -11363,14 +11363,17 @@ class Sema final : public SemaBase {
/// The context in which we are checking a template parameter list.
enum TemplateParamListContext {
-TPC_ClassTemplate,
-TPC_VarTemplate,
+// For this context, Class, Variable, TypeAlias, and non-pa
@@ -11363,14 +11363,17 @@ class Sema final : public SemaBase {
/// The context in which we are checking a template parameter list.
enum TemplateParamListContext {
-TPC_ClassTemplate,
-TPC_VarTemplate,
+// For this context, Class, Variable, TypeAlias, and non-pa
@@ -11363,14 +11363,17 @@ class Sema final : public SemaBase {
/// The context in which we are checking a template parameter list.
enum TemplateParamListContext {
-TPC_ClassTemplate,
-TPC_VarTemplate,
+// For this context, Class, Variable, TypeAlias, and non-pa
@@ -11363,14 +11363,17 @@ class Sema final : public SemaBase {
/// The context in which we are checking a template parameter list.
enum TemplateParamListContext {
-TPC_ClassTemplate,
-TPC_VarTemplate,
+// For this context, Class, Variable, TypeAlias, and non-pa
@@ -11363,14 +11363,17 @@ class Sema final : public SemaBase {
/// The context in which we are checking a template parameter list.
enum TemplateParamListContext {
-TPC_ClassTemplate,
-TPC_VarTemplate,
+// For this context, Class, Variable, TypeAlias, and non-pa
@@ -11363,14 +11363,17 @@ class Sema final : public SemaBase {
/// The context in which we are checking a template parameter list.
enum TemplateParamListContext {
-TPC_ClassTemplate,
-TPC_VarTemplate,
+// For this context, Class, Variable, TypeAlias, and non-pa
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/130447
When checking the template template parameters of template template parameters,
the PartialOrdering context was not correctly propagated.
This also has a few drive-by fixes, such as checking the template param
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Matheus Izvekov (mizvekov)
Changes
When checking the template template parameters of template template parameters,
the PartialOrdering context was not correctly propagated.
This also has a few drive-by fixes, such as checking the template
19 matches
Mail list logo
