https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/127675
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/127675
>From 2a288bc3528ae63f05551492518cbf500689108d Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 12 Feb 2025 15:45:32 -0500
Subject: [PATCH 1/6] [HLSL] Use hlsl_device address space for getpointer.
We ad
@@ -89,12 +89,12 @@ RESOURCE Buffer;
// CHECK-SAME{LITERAL}: [[hlsl::raw_buffer]]
// CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]]
-// CHECK-SUBSCRIPT: CXXMethodDecl {{.*}} operator[] 'const element_type
&(unsigned int) const'
+// CHECK-SUBSCRIPT: CXXMethodDecl
@@ -121,15 +121,15 @@ RESOURCE Buffer;
// CHECK-SUBSCRIPT-NEXT: DeclRefExpr {{.*}} 'unsigned int' ParmVar {{.*}}
'Index' 'unsigned int'
// CHECK-SUBSCRIPT-NEXT: AlwaysInlineAttr {{.*}} Implicit always_inline
-// CHECK-NOSUBSCRIPT-NOT: CXXMethodDecl {{.*}} operator[] 'const el
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/127675
>From 2a288bc3528ae63f05551492518cbf500689108d Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 12 Feb 2025 15:45:32 -0500
Subject: [PATCH 1/5] [HLSL] Use hlsl_device address space for getpointer.
We ad
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/127675
>From 81c31fcdee28482ceea703064b0103eccb2a93ad Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 12 Feb 2025 15:45:32 -0500
Subject: [PATCH 1/5] [HLSL] Use hlsl_device address space for getpointer.
We ad
@@ -89,12 +89,12 @@ RESOURCE Buffer;
// CHECK-SAME{LITERAL}: [[hlsl::raw_buffer]]
// CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]]
-// CHECK-SUBSCRIPT: CXXMethodDecl {{.*}} operator[] 'const element_type
&(unsigned int) const'
+// CHECK-SUBSCRIPT: CXXMethodDecl
@@ -121,15 +121,15 @@ RESOURCE Buffer;
// CHECK-SUBSCRIPT-NEXT: DeclRefExpr {{.*}} 'unsigned int' ParmVar {{.*}}
'Index' 'unsigned int'
// CHECK-SUBSCRIPT-NEXT: AlwaysInlineAttr {{.*}} Implicit always_inline
-// CHECK-NOSUBSCRIPT-NOT: CXXMethodDecl {{.*}} operator[] 'const el
https://github.com/hekota edited
https://github.com/llvm/llvm-project/pull/127675
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota approved this pull request.
LGTM! Just a couple of nits. Apologies for the delay, I was on vacation last
week. :)
https://github.com/llvm/llvm-project/pull/127675
___
cfe-commits mailing list
[email protected]
https:
https://github.com/Keenuts approved this pull request.
https://github.com/llvm/llvm-project/pull/127675
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
s-perron wrote:
@hekota Do you have any more things that need to be fixed?
https://github.com/llvm/llvm-project/pull/127675
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/127675
>From 81c31fcdee28482ceea703064b0103eccb2a93ad Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 12 Feb 2025 15:45:32 -0500
Subject: [PATCH 1/4] [HLSL] Use hlsl_device address space for getpointer.
We ad
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/127675
>From 81c31fcdee28482ceea703064b0103eccb2a93ad Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 12 Feb 2025 15:45:32 -0500
Subject: [PATCH 1/3] [HLSL] Use hlsl_device address space for getpointer.
We ad
@@ -751,13 +751,14 @@
BuiltinTypeDeclBuilder::addHandleAccessFunction(DeclarationName &Name,
using PH = BuiltinTypeMethodBuilder::PlaceHolder;
QualType ElemTy = getHandleElementType();
- // TODO: Map to an hlsl_device address space.
- QualType ElemPtrTy = AST.getPointer
@@ -89,12 +89,12 @@ RESOURCE Buffer;
// CHECK-SAME{LITERAL}: [[hlsl::raw_buffer]]
// CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]]
-// CHECK-SUBSCRIPT: CXXMethodDecl {{.*}} operator[] 'const element_type
&(unsigned int) const'
+// CHECK-SUBSCRIPT: CXXMethodDecl
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/127675
>From 81c31fcdee28482ceea703064b0103eccb2a93ad Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 12 Feb 2025 15:45:32 -0500
Subject: [PATCH 1/2] [HLSL] Use hlsl_device address space for getpointer.
We ad
@@ -751,13 +751,14 @@
BuiltinTypeDeclBuilder::addHandleAccessFunction(DeclarationName &Name,
using PH = BuiltinTypeMethodBuilder::PlaceHolder;
QualType ElemTy = getHandleElementType();
- // TODO: Map to an hlsl_device address space.
- QualType ElemPtrTy = AST.getPointer
@@ -89,12 +89,12 @@ RESOURCE Buffer;
// CHECK-SAME{LITERAL}: [[hlsl::raw_buffer]]
// CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]]
-// CHECK-SUBSCRIPT: CXXMethodDecl {{.*}} operator[] 'const element_type
&(unsigned int) const'
+// CHECK-SUBSCRIPT: CXXMethodDecl
@@ -2379,8 +2379,10 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned
BuiltinID, CallExpr *TheCall) {
auto *ResourceTy =
TheCall->getArg(0)->getType()->castAs();
QualType ContainedTy = ResourceTy->getContainedType();
-// TODO: Map to an hlsl_device addres
@@ -751,13 +751,14 @@
BuiltinTypeDeclBuilder::addHandleAccessFunction(DeclarationName &Name,
using PH = BuiltinTypeMethodBuilder::PlaceHolder;
QualType ElemTy = getHandleElementType();
- // TODO: Map to an hlsl_device address space.
- QualType ElemPtrTy = AST.getPointer
https://github.com/hekota requested changes to this pull request.
Looks mostly good, but I think there is an issue with the const-ness of the
subscript operator return value.
https://github.com/llvm/llvm-project/pull/127675
___
cfe-commits mailing lis
https://github.com/hekota edited
https://github.com/llvm/llvm-project/pull/127675
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/127675
>From 81c31fcdee28482ceea703064b0103eccb2a93ad Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 12 Feb 2025 15:45:32 -0500
Subject: [PATCH] [HLSL] Use hlsl_device address space for getpointer.
We add th
llvmbot wrote:
@llvm/pr-subscribers-backend-webassembly
Author: Steven Perron (s-perron)
Changes
We add the hlsl_device address space to represent the device memory
space as defined in section 1.7.1.3 of the [HLSL
spec](https://microsoft.github.io/hlsl-specs/specs/hlsl.pdf).
Fixes https:/
https://github.com/s-perron ready_for_review
https://github.com/llvm/llvm-project/pull/127675
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/127675
>From 769344277c6a870b149467fedbe6bcd668c83e95 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 12 Feb 2025 15:45:32 -0500
Subject: [PATCH] [HLSL] Use hlsl_device address space for getpointer.
We add th
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/127675
>From 7e1a486302d4029c926362287341cd79dcdc21cf Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 12 Feb 2025 15:45:32 -0500
Subject: [PATCH] [HLSL] Use hlsl_device address space for getpointer.
We add th
28 matches
Mail list logo
