https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/138519
>From cbbca4d26b8d00eb103f110c2341fab2e4a2e40d Mon Sep 17 00:00:00 2001
From: Oleksandr Tarasiuk
Date: Mon, 5 May 2025 15:30:14 +0300
Subject: [PATCH 1/2] [Clang] diagnose unknown attribute namespaces
---
c
a-tarasyuk wrote:
> So I don't believe this is correct either. We want it to always say the
> namespace. So clang::unknown will diagnose as unknown attribute
> 'clang::unknown' ignored
@erichkeane @AaronBallman Thanks for the feedback. I've made changes to include
the _scope_ in the diagnost
https://github.com/a-tarasyuk deleted
https://github.com/llvm/llvm-project/pull/138519
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/138519
>From cbbca4d26b8d00eb103f110c2341fab2e4a2e40d Mon Sep 17 00:00:00 2001
From: Oleksandr Tarasiuk
Date: Mon, 5 May 2025 15:30:14 +0300
Subject: [PATCH] [Clang] diagnose unknown attribute namespaces
---
clang
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/138519
>From 7d376b33f09801be504ec65a2853679dff8b726c Mon Sep 17 00:00:00 2001
From: Oleksandr Tarasiuk
Date: Mon, 5 May 2025 15:30:14 +0300
Subject: [PATCH 1/3] [Clang] diagnose unknown attribute namespaces
---
c
@@ -6861,13 +6861,19 @@ ProcessDeclAttribute(Sema &S, Scope *scope, Decl *D,
const ParsedAttr &AL,
// though they were unknown attributes.
if (AL.getKind() == ParsedAttr::UnknownAttribute ||
!AL.existsInTarget(S.Context.getTargetInfo())) {
-S.Diag(AL.getLoc(),
-
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/138519
>From 7d376b33f09801be504ec65a2853679dff8b726c Mon Sep 17 00:00:00 2001
From: Oleksandr Tarasiuk
Date: Mon, 5 May 2025 15:30:14 +0300
Subject: [PATCH 1/3] [Clang] diagnose unknown attribute namespaces
---
c
AaronBallman wrote:
> So I don't believe this is correct either. We want it to always say the
> namespace. So `clang::unknown` will diagnose as `unknown attribute
> 'clang::unknown' ignored` AFAIK. Right @AaronBallman ?
I think what I'm seeing is correct, unless I'm missing something. Attribut
@@ -6861,13 +6861,19 @@ ProcessDeclAttribute(Sema &S, Scope *scope, Decl *D,
const ParsedAttr &AL,
// though they were unknown attributes.
if (AL.getKind() == ParsedAttr::UnknownAttribute ||
!AL.existsInTarget(S.Context.getTargetInfo())) {
-S.Diag(AL.getLoc(),
-
https://github.com/erichkeane commented:
So I don't believe this is correct either. We want it to always say the
namespace. So `clang::unknown` will diagnose as `unknown attribute
'clang::unknown' ignored` AFAIK. Right @AaronBallman ?
https://github.com/llvm/llvm-project/pull/138519
___
@@ -385,6 +385,8 @@ related warnings within the method body.
- Clang now disallows the use of attributes applied before an
``extern template`` declaration (#GH79893).
+- Clang now diagnoses unknown attribute namespaces
a-tarasyuk wrote:
@erichkeane I’ve upd
https://github.com/a-tarasyuk edited
https://github.com/llvm/llvm-project/pull/138519
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/138519
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,san
@@ -385,6 +385,8 @@ related warnings within the method body.
- Clang now disallows the use of attributes applied before an
``extern template`` declaration (#GH79893).
+- Clang now diagnoses unknown attribute namespaces
erichkeane wrote:
```suggestion
- Clan
https://github.com/erichkeane commented:
I believe our feedback on the last one was to emit the namespace in all
attribute ignored diagnostics, not just if we don't know the namespace. So
unknown attribute `clang::whatever` as well?
Otherwise, I think this is a reasonable patch that makes thi
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/138519
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Oleksandr T. (a-tarasyuk)
Changes
This patch enhances Clang's attribute handling by diagnosing unknown attribute
namespaces
```c++
[[foo::nodiscard]] int f(); // warning: unknown attribute namespace 'unknown';
attribute 'unknown
https://github.com/a-tarasyuk created
https://github.com/llvm/llvm-project/pull/138519
This patch enhances Clang's attribute handling by diagnosing unknown attribute
namespaces
```c++
[[foo::nodiscard]] int f(); // warning: unknown attribute namespace 'unknown';
attribute 'unknown::foo' igno
18 matches
Mail list logo
