[clang] [Clang][NFC] Code cleanup in CGBuiltin.cpp (PR #132060)

2025-04-05 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: The timing of this is sort of unfortunate with #132252; the merge conflict there is going to be very painful. @jthackray , thoughts? https://github.com/llvm/llvm-project/pull/132060 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [Clang][NFC] Code cleanup in CGBuiltin.cpp (PR #132060)

2025-04-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/132060 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Code cleanup in CGBuiltin.cpp (PR #132060)

2025-04-04 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/132060 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Code cleanup in CGBuiltin.cpp (PR #132060)

2025-03-27 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Changes LGTM though I've added @efriedma-quic as a codegen code owner just in case he's got different opinions. https://github.com/llvm/llvm-project/pull/132060 ___ cfe-commits mailing list c

[clang] [Clang][NFC] Code cleanup in CGBuiltin.cpp (PR #132060)

2025-03-26 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/132060 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Code cleanup in CGBuiltin.cpp (PR #132060)

2025-03-20 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray edited https://github.com/llvm/llvm-project/pull/132060 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Code cleanup in CGBuiltin.cpp (PR #132060)

2025-03-20 Thread Jonathan Thackray via cfe-commits
jthackray wrote: > The timing of this is sort of unfortunate with #132252; the merge conflict > there is going to be very painful. @jthackray , thoughts? @efriedma-quic I think I can update my diff after this is merged; yes, might take a while to resolve the diffs. https://github.com/llvm/llv

[clang] [Clang][NFC] Code cleanup in CGBuiltin.cpp (PR #132060)

2025-03-19 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/132060 - Use `Intrinsic::` directly instead of `llvm::Intrinsic::`. - Eliminate redundant `nullptr` for some `CreateIntrinsic` calls. - Eliminate redundant `ArrayRef` casts. - Use C++17 structured binding instead of `st