[clang] [C++20] Fix crash with invalid concept requirement (PR #138877)

2025-05-08 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Does this also fix: #138823 I don't believe so, at least from my testing on godbolt (which should have my changes, from the git hash they have with --version). https://github.com/llvm/llvm-project/pull/138877 ___ cfe-commits mai

[clang] [C++20] Fix crash with invalid concept requirement (PR #138877)

2025-05-07 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Does this also fix: https://github.com/llvm/llvm-project/issues/138823 https://github.com/llvm/llvm-project/pull/138877 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/

[clang] [C++20] Fix crash with invalid concept requirement (PR #138877)

2025-05-07 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/138877 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] Fix crash with invalid concept requirement (PR #138877)

2025-05-07 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/138877 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] Fix crash with invalid concept requirement (PR #138877)

2025-05-07 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/138877 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] Fix crash with invalid concept requirement (PR #138877)

2025-05-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes We were previously recovering a bit too hard; consumeClose() would skip to a recovery point, then we would call skipToEnd() to skip to another recovery point. Needless to say, the follow-on diagnostics

[clang] [C++20] Fix crash with invalid concept requirement (PR #138877)

2025-05-07 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/138877 We were previously recovering a bit too hard; consumeClose() would skip to a recovery point, then we would call skipToEnd() to skip to another recovery point. Needless to say, the follow-on diagnostics wer