[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3678e16155: [Clang] [Docs] Add HLSLSupport page (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/docs/HLSLSupport.rst:150-152 +HLSL has a ``precise`` qualifier that behaves unlike anything else in the C +language. The support for this qualifier in DXC is buggy, so our bar for +comp

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

beanz added inline comments. Comment at: clang/docs/HLSLSupport.rst:150-152 +HLSL has a ``precise`` qualifier that behaves unlike anything else in the C +language. The support for this qualifier in DXC is buggy, so our bar for +compatibility is low. aaron.ballman

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

aaron.ballman added inline comments. Comment at: clang/docs/HLSLSupport.rst:150-152 +HLSL has a ``precise`` qualifier that behaves unlike anything else in the C +language. The support for this qualifier in DXC is buggy, so our bar for +compatibility is low. beanz

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

beanz updated this revision to Diff 421524. beanz added a comment. Updating based on feedback :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123278/new/ https://reviews.llvm.org/D123278 Files: clang/docs/HLSLSupport.rst clang/docs/index.rst

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

kuhar accepted this revision. kuhar added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/HLSLSupport.rst:223 +* References +* goto or labels +* Variable Length Arrays nit, for consistency with the other list items: make

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

beanz marked 30 inline comments as done. beanz added inline comments. Comment at: clang/docs/HLSLSupport.rst:150-152 +HLSL has a ``precise`` qualifier that behaves unlike anything else in the C +language. The support for this qualifier in DXC is buggy, so our bar for +compatibili

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

aaron.ballman added inline comments. Comment at: clang/docs/HLSLSupport.rst:150-152 +HLSL has a ``precise`` qualifier that behaves unlike anything else in the C +language. The support for this qualifier in DXC is buggy, so our bar for +compatibility is low. beanz

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

beanz updated this revision to Diff 421373. beanz added a comment. Updating with edits based on review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123278/new/ https://reviews.llvm.org/D123278 Files: clang/docs/HLSLSupport.rst clang

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

beanz added a comment. I'll do an edit pass tonight and update. I've also gone through and replied to some of the questions and comments inline. Thank you! Comment at: clang/docs/HLSLSupport.rst:22-23 +`_. in all its suppor

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

kuhar added inline comments. Comment at: clang/docs/HLSLSupport.rst:190 +* RTTI +* Exceptions +* Multiple inheritance How about goto and labels? Irreducible control flow? Are infinite loops valid? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

kuhar added a comment. Looks good to me overall, I just left some local comments. Please take my writing suggestions with a pinch of salt, English is my second language. Comment at: clang/docs/HLSLSupport.rst:13 +describes the high level goals of the project, the guiding princ

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

tschuett added a comment. Thanks. I let Aaron go over the details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123278/new/ https://reviews.llvm.org/D123278 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

aaron.ballman added a comment. Thanks for getting a start on this documentation, I appreciate it! Comment at: clang/docs/HLSLSupport.rst:11 + +HLSL Support is a new initiative underway in the Clang codebase. This document +describes the high level goals of the project, the guid

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

beanz created this revision. beanz added reviewers: tschuett, aaron.ballman, jaebaek, antiagainst, kuhar. Herald added a subscriber: arphaman. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This document