[PATCH] D123243: [pseudo] Strip directives from a token stream

2022-05-06 Thread Sam McCall via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7dc3c6190ec7: [pseudo] Strip directives from a token stream (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D123243: [pseudo] Strip directives from a token stream

2022-05-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 427581. sammccall marked an inline comment as done. sammccall added a comment. rebase add include to testcase rename preprocess => strip-includes, and testcase move print directivetree test to strip-includes.c fix tests to not cook before parsing directivetr

[PATCH] D123243: [pseudo] Strip directives from a token stream

2022-05-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/DirectiveTree.cpp:373 +case DirectiveTree::Chunk::K_Empty: + break; +} hokein wrote: > return, otherwise we we hit the unreachable c

[PATCH] D123243: [pseudo] Strip directives from a token stream

2022-05-03 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. would be nice to land it in some of form. Comment at: clang-tools-extra/pseudo/unittests/DirectiveTreeTest.cpp:316 + std::string Code = R"cpp( +a a a +#warning AAA -

[PATCH] D123243: [pseudo] Strip directives from a token stream

2022-04-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/DirectiveTree.cpp:373 +case DirectiveTree::Chunk::K_Empty: + break; +} return, otherwise we we hit the unreachable code below. Comment at: clang-tools-extra/pse

[PATCH] D123243: [pseudo] Strip directives from a token stream

2022-04-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. This includes only the taken branch of conditional sections