[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith updated this revision to Diff 411573. keith added a comment. Herald added subscribers: llvm-commits, delcypher. Herald added a project: LLVM. Move config to llvm lit config, add docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ h

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added inline comments. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: compnerd wrote: > This isn't really a separator, this is the root itself. I think that it > makes sense to name it accordingly.

[PATCH] D111457: [clang][test] Add lit helper for windows paths

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: This isn't really a separator, this

[PATCH] D111457: [clang][test] Add lit helper for windows paths

rnk added a comment. These seem like generic substitutions that would be useful to anyone writing lit tests. We already have `%{pathsep}`: https://llvm.org/docs/CommandGuide/lit.html#substitutions These should live there as well, and be documented similarly, I think. Repository: rG LLVM Gith

[PATCH] D111457: [clang][test] Add lit helper for windows paths

mstorsjo added a subscriber: rnk. mstorsjo added a comment. In D111457#3085273 , @keith wrote: > Yep this makes sense. I would rather not scope that into this if that's ok. > Since this test was already invalid and broken (actual fix in > https://review

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added a comment. In D111457#3082398 , @mstorsjo wrote: > In D111457#3073726 , @keith wrote: > >> In D111457#3066508 , @mstorsjo >> wrote: >> >>> Wouldn't this one a

[PATCH] D111457: [clang][test] Add lit helper for windows paths

mstorsjo added a comment. In D111457#3073726 , @keith wrote: > In D111457#3066508 , @mstorsjo > wrote: > >> Wouldn't this one also be solved pretty much the same, but differently, by >> changing `if (llvm::sys::

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added a comment. In D111457#3066508 , @mstorsjo wrote: > Wouldn't this one also be solved pretty much the same, but differently, by > changing `if (llvm::sys::path::is_absolute(RemappedFile)) {` into > `is_absolute_gnu`? I think it //could// but

[PATCH] D111457: [clang][test] Add lit helper for windows paths

mstorsjo added a comment. Wouldn't this one also be solved pretty much the same, but differently, by changing `if (llvm::sys::path::is_absolute(RemappedFile)) {` into `is_absolute_gnu`? Since we're remapping debug paths, it's plausible that the target path can be a different style (when cross c

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith updated this revision to Diff 378725. keith marked 2 inline comments as done. keith added a comment. Allow empty leading on windows This behavior is currently broken, the directory should never be `/` or `C:\` but the logic is broken and only handles `/` Repository: rG LLVM Github Mono

[PATCH] D111457: [clang][test] Add lit helper for windows paths

rmaz added inline comments. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: keith wrote: > rmaz wrote: > > `c:\`? > Do you mean lowercase or a single slash? I see ~2x the number of uppercase vs > lowercase i

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added inline comments. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: rmaz wrote: > `c:\`? Do you mean lowercase or a single slash? I see ~2x the number of uppercase vs lowercase in this codebase now,

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith updated this revision to Diff 378380. keith added a comment. Herald added a subscriber: ormris. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 Files: clang/test/CodeGen/debug-prefix-map

[PATCH] D111457: [clang][test] Add lit helper for windows paths

rmaz added inline comments. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: `c:\`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.l

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith created this revision. keith added reviewers: jroelofs, rmaz. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds 2 new lit helpers (only to the clang config) `%{rootsep}` and `%{sep}`, these allow writing tests that corre