https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/141293
>From bcee06004f24f8488bcc8e84170bf3509daa5fd9 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 23 May 2025 13:53:36 -0700
Subject: [PATCH] [alpha.webkit.NoUnretainedMemberChecker] Recognize
NS_REQUIRES_PRO
https://github.com/rniwa edited https://github.com/llvm/llvm-project/pull/141293
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/141293
>From bd7daa355f5c1924475c0818dd4963af7bbffcb1 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 23 May 2025 13:53:36 -0700
Subject: [PATCH 1/3] [alpha.webkit.NoUnretainedMemberChecker] Recocgnize
NS_REQUIRE
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/141293
>From bd7daa355f5c1924475c0818dd4963af7bbffcb1 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 23 May 2025 13:53:36 -0700
Subject: [PATCH 1/2] [alpha.webkit.NoUnretainedMemberChecker] Recocgnize
NS_REQUIRE
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/141293
Allow @property of a raw pointer when NS_REQUIRES_PROPERTY_DEFINITIONS is
specified on the interface since such an interface does not automatically
synthesize raw pointer ivars.
>From bd7daa355f5c1924475c0818dd4
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/141277
This PR adds the WebKit checker support for
[[clang::annotate_type("webkit.pointerconversion")]].
When this attribute is set on the return value of a function, the function is
treated as safe to call anywhere an
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/138042
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/138995
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/138995
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/138042
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/138995
>From d4b5f004e2d91e8d821e20bee6fcb43b87701b9d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Wed, 7 May 2025 16:53:35 -0700
Subject: [PATCH 1/3] [webkit.UncountedLambdaCapturesChecker] Treat every
argument of
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/138042
>From d03c8bb9915ff20c3936525a11a8ef113805b124 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 27 Apr 2025 16:52:13 -0700
Subject: [PATCH 1/2] [RawPtrRefMemberChecker] Add the support for union and
pointer
@@ -192,7 +202,8 @@ class RawPtrRefMemberChecker
const auto Kind = RD->getTagKind();
// FIMXE: Should we check union members too?
-if (Kind != TagTypeKind::Struct && Kind != TagTypeKind::Class)
+if (Kind != TagTypeKind::Struct && Kind != TagTypeKind::Class &&
-
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/138995
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-ser
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/138995
Functions in std::ranges namespace does not store the lambada passed-in as an
arugment in heap so treat such an argument as if it has [[noescape]] in the
WebKit lambda capture checker so that we don't emit warnin
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/138068
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/137476
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/138068
Allow copy capture of a reference to a CheckedPtr capable object since such a
capture will copy the said object instead of keeping a dangling reference to
the object.
Rate limit · GitHub
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/137476
>From c76e86105b5ba03cc2a3c8399670b2b38eb8e6ea Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sat, 26 Apr 2025 14:03:13 -0700
Subject: [PATCH 1/2] [WebKit checkers] Treat std::bit_cast as a pointer
conversion
@@ -462,7 +462,7 @@ bool isPtrConversion(const FunctionDecl *F) {
const auto FunctionName = safeGetName(F);
if (FunctionName == "getPtr" || FunctionName == "WeakPtr" ||
FunctionName == "dynamicDowncast" || FunctionName == "downcast" ||
- FunctionName == "checkedD
@@ -462,7 +462,7 @@ bool isPtrConversion(const FunctionDecl *F) {
const auto FunctionName = safeGetName(F);
if (FunctionName == "getPtr" || FunctionName == "WeakPtr" ||
FunctionName == "dynamicDowncast" || FunctionName == "downcast" ||
- FunctionName == "checkedD
rniwa wrote:
Closing this in favor of https://github.com/llvm/llvm-project/pull/138042.
https://github.com/llvm/llvm-project/pull/137566
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/137566
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/138042
This PR adds support for detecting unsafe union members and pointers to unsafe
pointers (e.g. T** where T* is an unsafe pointer type).
Rate limit · GitHub
body {
ba
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/137559
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/137559
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/137566
None
>From a04f65339530bea920c80dc1b2b0f3c9bab488c3 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 20 Apr 2025 18:38:31 -0700
Subject: [PATCH 1/2] [RawPtrRefMemberChecker] Make RawPtrRefMemberChecker
con
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/137565
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/137559
>From 9d6c807a5d7b853876132be0668357f6945978af Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 20 Apr 2025 18:38:31 -0700
Subject: [PATCH 1/2] [RawPtrRefMemberChecker] Make RawPtrRefMemberChecker
consisten
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/137565
None
>From 9d6c807a5d7b853876132be0668357f6945978af Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 20 Apr 2025 18:38:31 -0700
Subject: [PATCH 1/2] [RawPtrRefMemberChecker] Make RawPtrRefMemberChecker
con
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/137559
Refactor RawPtrRefMemberChecker so that each subclass override isUnsafePtr like
other WebKit checkers instead of overriding isPtrCompatible.
>From 9d6c807a5d7b853876132be0668357f6945978af Mon Sep 17 00:00:00 2001
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/137556
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Oops, fixing the assertion failure in
https://github.com/llvm/llvm-project/pull/137556.
https://github.com/llvm/llvm-project/pull/135329
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/137556
None
>From 46d5c45c4c7a6abe0255aa31e2c7435d7f3e8289 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 27 Apr 2025 15:16:40 -0700
Subject: [PATCH] [alpha.webkit.RetainPtrCtorAdoptChecker] Check nullity before
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/135329
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/135329
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/137476
WebKit repalced its use of WTF::bitwise_cast with std::bit_cast. Add the
support for recognizing it as a pointer conversion.
>From c76e86105b5ba03cc2a3c8399670b2b38eb8e6ea Mon Sep 17 00:00:00 2001
From: Ryosuke N
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/135688
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/135688
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/135688
>From 41992e5ffb43f7db7704b93c7ad5fe2135e86e26 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 14 Apr 2025 15:12:10 -0700
Subject: [PATCH 1/2] [webkit.UncountedLambdaCapturesChecker] Treat a call to
lambda
@@ -372,6 +372,14 @@ void trivial_lambda() {
trivial_lambda();
}
+bool call_lambda_var_decl() {
+ RefCountable* ref_countable = make_obj();
+ auto lambda = [&]() -> bool {
+return ref_countable->next();
+ };
+ return lambda();
+}
+
rniwa wrote:
Sure
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/136500
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thank you for the review!
https://github.com/llvm/llvm-project/pull/136500
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/136170
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thank you for the review!
https://github.com/llvm/llvm-project/pull/136170
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa edited https://github.com/llvm/llvm-project/pull/136503
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/136503
>From 01a0a5544010a605e828a28c04ba56d37658c6b0 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 20 Apr 2025 11:58:11 -0700
Subject: [PATCH] [RawPtrRefMemberChecker] Member variable checker should allow
T* i
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/136503
This PR fixes member variable checker to allow the usage of T* in smart pointer
classes. e.g. alpha.webkit.NoUncheckedPtrMemberChecker should allow T* to
appear within RefPtr.
>From 441e1d80180549ff17eb74e3749bc
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/136500
This PR fixes the bug that alpha.webkit.UncheckedCallArgsChecker did not
recognize CanMakeCheckedPtrBase due to getAsCXXRecordDecl returning nullptr for
it in hasPublicMethodInBase. Manually grab getTemplatedDecl
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/136170
This PR makes WebKit checkers treat a variable with global storage as safe
instead of constraining to ones that start with k or _k.
>From e051846bf5eeb0a6b4f701096e2d461b2c11254d Mon Sep 17 00:00:00 2001
From: Ry
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/135532
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/135532
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/135526
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/135688
This PR makes the checker ignore a function call to lambda via a local variable.
>From 41992e5ffb43f7db7704b93c7ad5fe2135e86e26 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 14 Apr 2025 15:12:10 -0700
Su
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/135526
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/135532
>From efd914e66352fdf7e9fac3355d0a06159e880987 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 13 Apr 2025 01:30:26 -0700
Subject: [PATCH 1/2] [alpha.webkit.UnretainedCallArgsChecker] Add the support
for R
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/135629
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/135629
None
>From 928db4c6ac01b96bbe65a9c3aec05c84c97a1040 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 14 Apr 2025 07:49:07 -0700
Subject: [PATCH] Remove the redundant check for "WeakPtr" in isSmartPtrClass
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/135532
>From efd914e66352fdf7e9fac3355d0a06159e880987 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 13 Apr 2025 01:30:26 -0700
Subject: [PATCH 1/3] [alpha.webkit.UnretainedCallArgsChecker] Add the support
for R
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/135532
WebKit uses #define to rename RetainPtr to RetainPtrArc so add the support for
it.
>From efd914e66352fdf7e9fac3355d0a06159e880987 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 13 Apr 2025 01:30:26 -0700
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/135526
Generalize the check for operator= so that it works for RetainPtr and
CheckedPtr instead of just RefPtr.
>From 6ca0049fdbc74a9f408b17d62260d6ff7d511ae4 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 13 A
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/135329
>From ffeb0f6f3252579fe77460ba05b57f7b68189bab Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 11 Apr 2025 01:15:55 -0700
Subject: [PATCH 1/3] [alpha.webkit.RetainPtrCtorAdoptChecker] An assortment of
smal
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/135329
>From ffeb0f6f3252579fe77460ba05b57f7b68189bab Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 11 Apr 2025 01:15:55 -0700
Subject: [PATCH 1/2] [alpha.webkit.RetainPtrCtorAdoptChecker] An assortment of
smal
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/134545
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/134545
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/132316
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/132316
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/132518
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/132518
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/132316
>From 642057c409b1c3b98ee4ecb16e95b5fb5be47a01 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 20 Mar 2025 17:54:22 -0700
Subject: [PATCH 1/3] [alpha.webkit.RetainPtrCtorAdoptChecker] Support
adopt(cast(co
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/132350
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -448,6 +483,10 @@ class UnretainedLambdaCapturesChecker : public
RawPtrRefLambdaCapturesChecker {
return RTC->isUnretained(QT);
}
+ virtual bool isPtrType(const std::string &Name) const final {
rniwa wrote:
Yes, line 290 / 300 and line 318 / 334.
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/132350
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -97,3 +97,13 @@ void create_member_init() {
RetainPtr return_bridge_cast() {
return bridge_cast(create_cf_array());
}
+
+void mutable_copy() {
+ RetainPtr mutableArray = adoptNS(@{
+@"Content-Type": @"text/html",
+ }.mutableCopy);
+}
+
+void string_copy(NSString *str
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/134545
>From a6c4a36a0c7a9b24e0f44748f3d92eee013ab645 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 6 Apr 2025 09:26:33 -0700
Subject: [PATCH 1/2] [alpha.webkit.ForwardDeclChecker] Recognize a forward
declared
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/134545
This PR fixes a bug that when a template specialization is declared with a
forward declaration of a template, the checker fails to find its definition in
the same translation unit and erroneously emit an unsafe f
https://github.com/rniwa unassigned
https://github.com/llvm/llvm-project/pull/132518
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/133341
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/133605
Objective-C selectors are supposed to return autoreleased object. Treat these
return values as safe.
>From 02340f3d1f51ae69598a8725403d4835f29f17cd Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sat, 29 Mar 2
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/133755
>From 0fb864bc5ae7d2b58879a6ad59babffe722bbf72 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 31 Mar 2025 10:11:10 -0700
Subject: [PATCH 1/2] [alpha.webkit.NoUnretainedMemberChecker] Ignore
system-header-
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/133804
>From f5d2ab90f34cf2d7323e9c3c2e37680c35f411d6 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 31 Mar 2025 14:38:22 -0700
Subject: [PATCH 1/2] [alpha.webkit.ForwardDeclChecker] Ignore forward declared
stru
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/131500
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -133,6 +141,36 @@ class RawPtrRefMemberChecker
std::optional IsCompatible = isPtrCompatible(QT, IvarCXXRD);
if (IsCompatible && *IsCompatible)
reportBug(Ivar, IvarType, IvarCXXRD, CD);
+} else {
+ std::optional IsCompatible = isPtrCompatible(QT,
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/132784
Recognize dynamic_objc_cast, checked_objc_cast, dynamic_cf_cast, and
checked_cf_cast.
>From aed6967708809b964c4969ec4e6477dade61132d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 24 Mar 2025 10:13:16 -0
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/133804
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thank you!
https://github.com/llvm/llvm-project/pull/133804
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/132316
>From 642057c409b1c3b98ee4ecb16e95b5fb5be47a01 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 20 Mar 2025 17:54:22 -0700
Subject: [PATCH 1/3] [alpha.webkit.RetainPtrCtorAdoptChecker] Support
adopt(cast(co
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/133605
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/133605
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/133755
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the quick review!
https://github.com/llvm/llvm-project/pull/133755
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/133804
>From f5d2ab90f34cf2d7323e9c3c2e37680c35f411d6 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 31 Mar 2025 14:38:22 -0700
Subject: [PATCH 1/3] [alpha.webkit.ForwardDeclChecker] Ignore forward declared
stru
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/133804
There are some system libraries such as sqlite3 which forward declare a struct
then use a pointer to that forward declared type in various APIs. Ignore these
types ForwardDeclChecker like other pointer types.
>F
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/133755
Prior to this PR, we were emitting warnings for Objective-C ivars and
properties if the forward declaration of the type appeared first in a
non-system header. This PR fixes the checker so tha we'd ignore ivars an
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/132833
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/132833
>From ca50deea7d8096b065d2bf7aa5e007afc8f0a954 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 24 Mar 2025 14:22:28 -0700
Subject: [PATCH 1/5] [alpha.webkit.RawPtrRefMemberChecker] The checker doesn't
warn
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/132833
>From ca50deea7d8096b065d2bf7aa5e007afc8f0a954 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 24 Mar 2025 14:22:28 -0700
Subject: [PATCH 1/4] [alpha.webkit.RawPtrRefMemberChecker] The checker doesn't
warn
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/132833
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -273,11 +279,148 @@ inline CFTypeRef bridge_cast(NSObject *object)
return (__bridge CFTypeRef)object;
}
+template
+struct ObjCTypeCastTraits {
+public:
+static bool isType(id object) { return [object isKindOfClass:[ExpectedType
class]]; }
+
+template
+sta
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/133341
None
>From 13115c0d14953c01dba10c4fbb38e149acce6c34 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 27 Mar 2025 16:24:23 -0700
Subject: [PATCH] Fix the assertion failure in
Analysis/Checkers/WebKit/forwar
1 - 100 of 754 matches
Mail list logo
