sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clangd/CodeCompletionStrings.h:46 const CodeCompleteConsumer::OverloadCandidate &Result, - unsigned ArgIndex); + unsigned ArgIndex, bool NoCommentsFromHeaders = true); ---------------- this invites double negation. Also it doesn't seem like a great default, violates principle of least surprise. prefer bool CommentsFromHeaders = true, or with no default. (or even consider an enum) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47274 _______________________________________________ cfe-commits mailing list [email protected] http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits