================ @@ -33,6 +33,14 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy { llvm_unreachable("NYI: PPC double-double format for long double"); llvm_unreachable("Unsupported format for long double"); } + + bool isSized(mlir::Type ty) { + if (mlir::isa<cir::PointerType, cir::ArrayType, cir::BoolType, + cir::IntType>(ty)) + return true; + assert(0 && "Unimplemented size for type"); ---------------- erichkeane wrote:
I think it isn't quite that.... there is an NYI state here as well. If we dont' expect non-CIR MLIR types, an unreachable would be appropriate here instead. IF all CIR-MLIR types are sized, asking this question seems silly. https://github.com/llvm/llvm-project/pull/130502 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits