jplehr added inline comments.
================ Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10412 + CGF.Builder.GetInsertPoint()); + llvm::OpenMPIRBuilder::LocationDescription ompLoc(CodeGenIP); ---------------- capitalize here? ================ Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10424 + llvm::Value *IfCondVal = nullptr; + bool CondConstant; + if (IfCond) { ---------------- I think this can (and should be?) moved into the if in the following line as it is not used outside that scope Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits